Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calib3d undistortion grid #23305

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Fix calib3d undistortion grid #23305

merged 2 commits into from
Mar 10, 2023

Conversation

bhavitp
Copy link
Contributor

@bhavitp bhavitp commented Feb 26, 2023

Resolves #23304

Fixes the incorrect pixel grid
Switches type to double to avoid precision loss as all callers use doubles

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov changed the title Fix/calib3d/undistortion grid Fix calib3d undistortion grid Feb 27, 2023
@vpisarev
Copy link
Contributor

vpisarev commented Mar 9, 2023

@bhavitp, thank you for the contribution! 👍

@asmorkalov asmorkalov merged commit 7ea6b35 into opencv:3.4 Mar 10, 2023
@asmorkalov asmorkalov added the bug label Mar 10, 2023
@asmorkalov asmorkalov added this to the 3.4.20 milestone Mar 10, 2023
@bhavitp bhavitp deleted the fix/calib3d/undistortion_grid branch March 10, 2023 15:12
@asmorkalov asmorkalov mentioned this pull request Apr 20, 2023
@asmorkalov asmorkalov added the port/backport done Label for maintainers. Authors of PR can ignore this label May 25, 2023
asmorkalov added a commit to asmorkalov/opencv that referenced this pull request May 25, 2023
asmorkalov added a commit to asmorkalov/opencv that referenced this pull request May 25, 2023
@asmorkalov asmorkalov mentioned this pull request May 31, 2023
asmorkalov added a commit to asmorkalov/opencv that referenced this pull request Jul 4, 2023
thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
…_grid

Resolves opencv#23304

Fixes the incorrect pixel grid
Switches type to double to avoid precision loss as all callers use doubles

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [X] I agree to contribute to the project under Apache 2 License.
- [X] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [X] The PR is proposed to the proper branch
- [X] There is a reference to the original bug report and related work
- [X] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [X] The feature is well documented and sample code can be built with the project CMake
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
…_grid

Resolves opencv#23304

Fixes the incorrect pixel grid
Switches type to double to avoid precision loss as all callers use doubles

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [X] I agree to contribute to the project under Apache 2 License.
- [X] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [X] The PR is proposed to the proper branch
- [X] There is a reference to the original bug report and related work
- [X] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [X] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category: calib3d port/backport done Label for maintainers. Authors of PR can ignore this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants